Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI-check: convey which part failed on GitHub #174

Open
gilles-peskine-arm opened this issue Aug 26, 2024 · 0 comments
Open

ABI-check: convey which part failed on GitHub #174

gilles-peskine-arm opened this issue Aug 26, 2024 · 0 comments
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

The “ABI-check” job can fail for three kinds of reasons:

  • API change
  • ABI change
  • Loss of test coverage

The goal of this test is to make the failure reason(s) apparent in the GitHub reporting. Currently, all we see is “Failures: ABI-API-checking”. Instead we should see something like “Failures: ABI, test coverage”.

This will need changes to the Groovy code but may also need changes to abi_check.py.

We should do this before we do API-breaking changes for 4.0, because we expect to have a lot of API breaks but we don't want do accidentally ignore a loss of test coverage.

Related: #48

@gilles-peskine-arm gilles-peskine-arm added enhancement New feature or request size-s Estimated task size: small (~2d) labels Aug 26, 2024
@Mbed-TLS Mbed-TLS deleted a comment Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Status: No status
Development

No branches or pull requests

2 participants
@gilles-peskine-arm and others