Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pop-up to reorder files when opening multiple logs on Windows (+Linux?) #239

Open
jashow55 opened this issue Oct 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jashow55
Copy link

Describe the bug
When multiple files are opened, it seems to sort them alphabetically by filename and that determines the order they are assigned to be Log0, Log1, Log2 ....
The order the files are selected is not used.
The saved layout is expecting a certain logfile as Log0, Log1, Log2, etc...So if the order is not correct the layout fails to get the data.

To Reproduce
Make a layout that uses, say 2 files, select files using ctrl left mouse-click such that the file alphabetically last if the first you select. It will not be Log0, it will be Log1.

Expected behavior
Want the selected order to be used.

Screenshots

Version (required):
using windows11, AdvantageScope v3.2.1

Additional context
Maybe fix might become feature request if you can reorder the files after opening.

@jashow55 jashow55 added the bug Something isn't working label Oct 20, 2024
@jwbonner
Copy link
Member

AdvantageScope uses the native file selector for each operating system, which means that this behavior is inconsistent across operating systems. The behavior on macOS matches what you're requesting, but Windows sorts the files alphabetically before returning them to AdvantageScope. Changing file paths after the logs are decoded is a bit tricky, but I could potentially add a pop-up to reorder files when multiple logs are selected (on Windows at least, and Linux if that's also an issue).

@jwbonner jwbonner changed the title Open Multiple ignores the selected order of the files Add pop-up to reorder files when opening multiple logs on Windows (+Linux?) Oct 20, 2024
@jwbonner jwbonner added enhancement New feature or request and removed bug Something isn't working labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants