From c8f299ec5d2467cbdddeb768434bd0d80a72e603 Mon Sep 17 00:00:00 2001 From: Boubaker Khanfir Date: Sun, 15 Sep 2024 12:47:32 +0100 Subject: [PATCH] feat: use new centralized space API with ACL management - MEED-7488 - Meeds-io/MIPs#147 This change will reuse the centralized way to check user priviledges on spaces contents. --- .../io/meeds/analytics/portlet/AbstractAnalyticsPortlet.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/analytics-webapps/src/main/java/io/meeds/analytics/portlet/AbstractAnalyticsPortlet.java b/analytics-webapps/src/main/java/io/meeds/analytics/portlet/AbstractAnalyticsPortlet.java index 9765a0034..4504b3f1f 100644 --- a/analytics-webapps/src/main/java/io/meeds/analytics/portlet/AbstractAnalyticsPortlet.java +++ b/analytics-webapps/src/main/java/io/meeds/analytics/portlet/AbstractAnalyticsPortlet.java @@ -218,7 +218,7 @@ protected SearchScope getSearchScope(PortletRequest request) { // NOSONAR Space space = SpaceUtils.getSpaceByContext(); if (space != null) { - if (getSpaceService().isSuperManager(userId) || getSpaceService().isMember(space, userId)) { + if (getSpaceService().canViewSpace(space, userId)) { return cacheSearchScope(portletSession, SearchScope.SPACE); } else { return cacheSearchScope(portletSession, SearchScope.NONE); @@ -256,7 +256,7 @@ protected boolean canModifySettings(PortletRequest request) { } Space space = SpaceUtils.getSpaceByContext(); if (space != null) { - boolean canModify = getSpaceService().isSuperManager(userId) || getSpaceService().isManager(space, userId); + boolean canModify = getSpaceService().canManageSpace(space, userId); return cacheChartModificationAccessPermission(portletSession, canModify); } return cacheChartModificationAccessPermission(portletSession, false);