Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.50.01-2024-10-05] Input lag in find parts search window #5016

Open
7 tasks done
WeaverThree opened this issue Oct 9, 2024 · 1 comment
Open
7 tasks done

[0.50.01-2024-10-05] Input lag in find parts search window #5016

WeaverThree opened this issue Oct 9, 2024 · 1 comment
Labels
Performance Severity: Low Issues described as low severity as per the new issue form

Comments

@WeaverThree
Copy link
Collaborator

Prerequisites and Pre-Issue Checklist

  • I'm reporting the issue to the correct repository:

  • MegaMek

  • MegaMekLab

  • MekHQ

  • I've tested the issue against at least the latest MILESTONE version

  • I've asked on the MegaMek Discord about the error

  • I've reviewed the BattleTech rules and MekHQ documentation, and I've confirmed that something isn't working as intended.

  • I've searched the Github tracker and haven't found the issue listed

Severity *

Low (Minor/Nuisance): Minor glitches or cosmetic issues that don’t affect gameplay and occur rarely.

Brief Description *

When you type in the find parts search dialog, there is a large lag before your keypresses start being registered. It's very appearant when typing inferno quickly. For met it lags and then the whole word appears. Presumably this is it finding all items conatining an i before considering further input.

I'd suggest adding a 50-100ms delay before the search happens if it's possible, so that if a user is typing quickly the search doesn't activate before their continued keypresses. It'd probably be good practice for all search fields, but this is the one that lags.

This window, to be clear:

2024-10-09_153413

Steps to Reproduce

  1. Get into a campaign
  2. Go to find parts
  3. Type rapidly into the search field

Operating System *

Linux

Java Version *

17.0.12

MekHQ Suite Version *

Free Text (type manually)

Custom MekHQ Version

v0.50.01-SNAPSHOT 2024-10-05

Attach Files

mekhq.MekHQ.initializeLogging(MekHQ.java:306) - Starting MekHQ v0.50.1-SNAPSHOT
Build Date: 2024-10-06T03:25:24.214306127
Today: 2024-10-09
Origin Project: MekHQ
Java Vendor: Eclipse Adoptium
Java Version: 17.0.12
Platform: Linux 6.11.2-202.fsync.fc40.x86_64 (amd64)
System Locale: en_US
Total memory available to MekHQ: 8 GB
MM Code Revision: 82fc89ceba5bfdb40670ba90bdc3e3ca1027a07b
MML Code Revision: 446bd8d9c7e28bfdf49d35f312d838c44e16941a
MHQ Code Revision: 976204b

Final Checklist

  • I've checked to make sure that this issue has not already been filed
  • I'm reporting only one issue in this ticket for clarity and focus
@repligator
Copy link
Collaborator

In other (not sure what the correct term is here) 'instant search systems' I've seen, it won't actually search until you type in a certain number of characters. In the case of MHQ, I think not searching until at least two characters are entered would be worth looking into.

@HammerGS HammerGS added the Severity: Low Issues described as low severity as per the new issue form label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Development

No branches or pull requests

3 participants