Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHubEventType #26

Open
Meisolsson opened this issue Feb 23, 2019 · 2 comments
Open

Update GitHubEventType #26

Meisolsson opened this issue Feb 23, 2019 · 2 comments

Comments

@Meisolsson
Copy link
Owner

I've been doing some checks on what is actually sent to the timeline and we have som extra things which are only sent to Web Hooks. We are also missing some events.

Here are the lists:

No longer in timeline

  • DownloadEvent
  • FollowEvent
  • ForkApplyEvent
  • GistEvent

Never been on timeline

  • DeploymentEvent
  • DeploymentStatusEvent
  • GitHubAppAuthorizationEvent
  • LabelEvent
  • MembershipEvent
  • MilestoneEvent
  • OrganizationEvent
  • OrgBlockEvent
  • PageBuildEvent
  • RepositoryEvent
  • StatusEvent
  • TeamEvent
  • TeamAddEvent

Only for GitHub apps

  • ContentReferenceEvent

Currenly missing in library

  • InstallationEvent
  • InstallationRepositoriesEvent
  • MarketplacePurchaseEvent
  • ProjectCardEvent
  • ProjectColumnEvent
  • ProjectEvent
  • PullRequestEvent
  • RepositoryImportEvent
  • RepositoryVulnerabilityAlertEvent
  • SecurityAdvisoryEvent

Not sure

  • CheckRunEvent
  • CheckSuiteEvent

@maniac103 I'd like some input on this and I know you guys use the library. Anything here that you can see is wrong?

@maniac103
Copy link
Contributor

@Meisolsson List looks good with the exception of PullRequestEvent: this most definitely is present in the library, as we're currently using it already: this is the list of events we're using.

@Meisolsson
Copy link
Owner Author

Alright, I think that one slipped when I was comparing everything. I'll get to doing this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants