Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config definitions and defaults #71

Open
pnadolny13 opened this issue Oct 10, 2022 · 0 comments
Open

Improve config definitions and defaults #71

pnadolny13 opened this issue Oct 10, 2022 · 0 comments

Comments

@pnadolny13
Copy link
Collaborator

We extract configs like encoding and others through the code (e.g. encoding default definitions) and cast to the defaults. It would be better to do the default coalescing at the top most level for consistency, to allow --about to return those defaults, and for better readability.

Also we define the files array in meltano.yml without the rich type definitions. We should update that to include the full output of --about --format=json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@pnadolny13 and others