Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL cities #24

Open
programmister opened this issue Jan 13, 2018 · 4 comments
Open

ALL cities #24

programmister opened this issue Jan 13, 2018 · 4 comments

Comments

@programmister
Copy link

Hello!

I read issue #18 about all cities. So could you please make additional db with all-all cities? It is VERY need.

@chriys
Copy link

chriys commented Jan 21, 2018

@programmister @dusterio suggested maybe a different package for smaller cities. Don't know yet how he's thinking it'll go since, if I remember correctly, the main reason for not including all-all cities was due to performance.
Maybe once a country is chosen all-all cities could then be loaded.
What are your thouhgts ?

@programmister
Copy link
Author

@chriys , now the cities over all countries are loaded at once?

@chriys
Copy link

chriys commented Jan 26, 2018

@programmister as far as I remember nope. I could submit a PR, just waiting for Duster to know which directly will be more appropriate.
It could be one of these:

  • show all cities from a country
  • a dedicated method to show small cities, from a country.

@tillkruss
Copy link

Instead of limiting to 50k residents, maybe we just grab the top 25 cites sorted by residents?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants