Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a decision regarding allowed region names #54

Open
bencopl opened this issue Aug 26, 2022 · 0 comments
Open

Make a decision regarding allowed region names #54

bencopl opened this issue Aug 26, 2022 · 0 comments
Labels
question Further information is requested

Comments

@bencopl
Copy link

bencopl commented Aug 26, 2022

Currently it's hard to write a unit test for the region name as what's allowed depends entirely on the limitations (or seemingly lack of limitations) of std::string.

I've tried passing through super long region names, blank spaces, non-null-terminated strings, special characters etc. but it seems to be OK with all of them.

If we want some region to be not allowed, I think we will have to make assertions for it within the code or something similar that can easily be unit tested.

Reasons for not allowing certain things might be just be to make sure the output looks nice (e.g. isn't formatted weirdly because a region name is 100 characters, or has random gibberish due to non-null-terminated strings).

@bencopl bencopl added the question Further information is requested label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant