Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constraints entry for removing prepack build script from packages #1906

Closed
MajorLift opened this issue Oct 24, 2023 · 0 comments · Fixed by #1907
Closed

Add constraints entry for removing prepack build script from packages #1906

MajorLift opened this issue Oct 24, 2023 · 0 comments · Fixed by #1907
Assignees
@MajorLift
Labels
team-wallet-framework

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Oct 24, 2023 •
edited
Loading

The prepack build script from incoming migration packages interfere with the release CI and need to be replaced with the prepack script in the root package.json.

This constraints.pro rule should enforce that redundant prepack scripts in non-root packages are removed.

          This should be enforced by constraints probably.

Originally posted by @Mrtenz in #1902 (review)

Removing redundant/irrelevant build scripts has been added as a step in the migration checklist: #1551 (comment) (B-3)
@MajorLift MajorLift mentioned this issue Oct 24, 2023
Merged
3 tasks
@MajorLift MajorLift self-assigned this Oct 24, 2023
MajorLift added a commit that referenced this issue Oct 24, 2023
@MajorLift
Adds constraints.pro rule that removes prepack build scripts (#1907)
ed03f8e 
## Explanation

The `prepack` build script from incoming migration packages interfere with the release CI and need to be replaced with the `prepack` script in the root `package.json`. 

This `constraints.pro` rule enforces that redundant `prepack` scripts in non-root packages are removed. 

## References

- See #1902
- See https://github.com/MetaMask/core/actions/runs/6629214754/job/18008299892?pr=1897
- Closes #1906

## Changelog

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds constraints.pro rule that removes prepack build scripts MetaMask/core
1 participant
@MajorLift