Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SafeEventEmitterProvider as a value, not just a type #1974

Closed
mcmire opened this issue Apr 6, 2023 · 1 comment
Closed

Expose SafeEventEmitterProvider as a value, not just a type #1974

mcmire opened this issue Apr 6, 2023 · 1 comment
Assignees
@MajorLift
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Apr 6, 2023

This is so that we can use this to create a fake provider object, as in the network clients in NetworkController (see #1116, packages/network-controller/tests/fake-provider-engine.ts, for the original source)
@mcmire mcmire mentioned this issue Apr 6, 2023
Merged
3 tasks
@mcmire mcmire mentioned this issue Jul 14, 2023
Open
@MajorLift MajorLift transferred this issue from MetaMask/eth-json-rpc-provider Nov 1, 2023
@MajorLift MajorLift mentioned this issue Nov 1, 2023
Closed
@MajorLift
Copy link
Contributor

Closed by #1738.

Relevant comments:

@MajorLift MajorLift self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcmire @MajorLift