Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CurrencyRateController] Consider serializing rates as strings instead of numbers #4857

Open
bergeron opened this issue Oct 28, 2024 · 0 comments
Open

[CurrencyRateController] Consider serializing rates as strings instead of numbers #4857

bergeron opened this issue Oct 28, 2024 · 0 comments
Labels
team-assets

Comments

@bergeron
Copy link
Contributor

To avoid precision loss, consider serializing the responses from cryptocompare as strings instead of how response.json() currently serializes them to JS numbers.

See https://github.com/MetaMask/core/pull/4852/files#r1817508642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-assets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@desi @bergeron