Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Storybook PR Builds from CircleCI to GitHub Workflows' #607

Open
georgewrmarshall opened this issue Feb 2, 2024 · 0 comments
Open
Assignees
Labels
code Issue related to code work team-design-system All issues relating to design system

Comments

@georgewrmarshall
Copy link
Collaborator

Description

We need to move our Storybook PR builds from CircleCI to GitHub workflows. This change will help streamline our CI/CD process and keep all our build processes in one place.

Technical Details

  • Move metamaskbot-build annouce .circleci/scripts/metamaskbot-build-announce.js
  • Migrate .circleci/config.yml to use github workflows in .github/workflows
  • Reuse .github/workflows/build-deploy-storybook.yml

Acceptance Criteria

  • Storybook PR builds are successfully running on GitHub workflows.
  • CircleCI is no longer used for Storybook PR builds.
  • The new workflow should trigger on every PR and update the status checks on GitHub.

Additional Information

Once the new workflow is set up, it should be tested with a few PRs to ensure it works as expected. We should also update any documentation or scripts that reference the old CircleCI process.

@georgewrmarshall georgewrmarshall added code Issue related to code work team-design-system All issues relating to design system labels Feb 2, 2024
@georgewrmarshall georgewrmarshall self-assigned this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Issue related to code work team-design-system All issues relating to design system
Projects
None yet
Development

No branches or pull requests

1 participant