Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shadows V2 and bump version up to next minor version #723

Open
brianacnguyen opened this issue Jun 6, 2024 · 1 comment
Open
Assignees
Labels
team-design-system All issues relating to design system

Comments

@brianacnguyen
Copy link
Contributor

brianacnguyen commented Jun 6, 2024

Implement the revamped shadows. Detailed changes below

  1. Updated shadow values for all sizes.
  2. Added XL size
  3. Updated shadow color token values.
  4. Added "inset-top" "inset-bottom" shadows. (Need to discuss how this gets implemented)

image.png


image.png


  • New "inset" shadows : HERE

image.png


FIGMA - SHADOW v2 (branch)

Acceptance Criteria

References

@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system label Jun 6, 2024
@brianacnguyen brianacnguyen changed the title Implement Shadows V2 Implement Shadows V2 and bump version up to next minor version Jun 6, 2024
@Akatori-Design
Copy link
Contributor

Made a quick fix to the branch

FIXES

  • Changed dark mode shadow opacity from 40% to 20%
  • Fixed light mode overlay color from #000 40% to #000 60% to match production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

No branches or pull requests

2 participants