From eb8d1f15cbb690b80850c3928e43555987a4cc42 Mon Sep 17 00:00:00 2001 From: George Marshall Date: Fri, 15 Nov 2024 16:13:07 -0800 Subject: [PATCH] fix: publish preview builds (#121) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** This PR addresses an issue with publishing preview builds in the MetaMask design system. The current setup was broken when https://github.com/MetaMask/metamask-design-system/pull/99 was merged as stated in this comment https://github.com/MetaMask/metamask-design-system/pull/99#pullrequestreview-2431161703. ## **Related issues** Fixes: https://github.com/MetaMask/metamask-design-system/issues/102 ## **Manual testing steps** 1. Trigger a preview build publish. 2. Verify that the build completes successfully without errors. 3. Confirm that the preview build is accessible and functions as expected for end users. ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs). - [x] I’ve completed the PR template to the best of my ability. - [x] I’ve included tests if applicable. - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I’ve manually tested the PR (e.g., pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria and includes necessary testing evidence, such as recordings or screenshots. --------- Co-authored-by: Brian August Nguyen --- .github/workflows/publish-preview.yml | 2 +- package.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish-preview.yml b/.github/workflows/publish-preview.yml index 18981b83..c2028b92 100644 --- a/.github/workflows/publish-preview.yml +++ b/.github/workflows/publish-preview.yml @@ -53,7 +53,7 @@ jobs: id: commit-sha run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT" - run: yarn prepare-preview-builds @metamask-previews ${{ steps.commit-sha.outputs.COMMIT_SHA }} - - run: yarn build + - run: yarn build:previews - name: Publish preview build run: yarn publish-previews env: diff --git a/package.json b/package.json index a513341b..80186b18 100644 --- a/package.json +++ b/package.json @@ -16,6 +16,7 @@ "build": "yarn ts-bridge --project tsconfig.build.json --verbose && yarn workspace @metamask/design-system-twrnc-preset build && yarn workspace @metamask/design-system-react-native build", "build:clean": "rimraf dist '**/*.tsbuildinfo' && yarn build", "build:docs": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run build:docs", + "build:previews": "yarn ts-bridge --project tsconfig.build.json --verbose && yarn workspace @metamask-previews/design-system-twrnc-preset build && yarn workspace @metamask-previews/design-system-react-native build", "build:types": "tsc --build tsconfig.build.json --verbose", "changelog:update": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:update", "changelog:validate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:validate",