Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether to remove ethereumjs-abi in favor of @metamask/abi-utils #16581

Closed
mikesposito opened this issue Nov 18, 2022 · 4 comments
Closed

Comments

@mikesposito
Copy link
Member

The ethereumjs-abi includes ethereumjs-util in dependencies. We should see if we can substitute it with our own package @metamask/abi-utils across the dep tree

Schermata 2022-11-18 alle 10.58.44.png

@adonesky1
Copy link
Contributor

adonesky1 commented Jan 17, 2023

Ok we definitely need to replace ethereumjs-abi with @metamask/abi-utils otherwise we can't remove old (pre v8) ethereumjs-utils which is required to fully replace secp256k1 implementation with the noble implemenations.

@mikesposito
Copy link
Member Author

mikesposito commented Jan 17, 2023

Ok we definitely need to replace ethereumjs-abi with @metamask/abi-utils otherwise we can't remove old (pre v8) ethereumjs-utils which is required to fully replace secp256k1 implementation with the noble implemenations.

Besides the direct dependency in metamask-crx, this goes away after updating @metamask/eth-sig-util to latest (#15906)

@adonesky1
Copy link
Contributor

Yes that's right @mikesposito . Just wanted to state that we do need to do this since this ticket is an "investigation" ticket

@adonesky1
Copy link
Contributor

Going to create a ticket to replace ethereumjs-abi with @metamask/abi-utils in metamask-crx since the other cases are covered by an existing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants