Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services.yml file is outdated #16

Open
omarlopesino opened this issue Oct 7, 2024 · 1 comment
Open

Services.yml file is outdated #16

omarlopesino opened this issue Oct 7, 2024 · 1 comment

Comments

@omarlopesino
Copy link
Member

omarlopesino commented Oct 7, 2024

Problem

Currently, services.yml file is outdated. It misses some new settings that have been added in the latest Drupal versions.

This is a problem easy to see by just copying default.services.yml into services.yml. It will only add new variables, or update the existing comments.

This produces problems like, for example, when you do a fresh install, , Samesite cookie is not configured to Lax,. This is inmediately fixed with a fresh services.yml file copied from default.services.yml. There are more configurations that are missing and may be producing to miss important configuration.

Proposed solution

Don't commit services.yml as we are not adding special configuration. When the file is not present, it will take the default configuration.

When developers wants override services.yml, they can do it by copying default.services.yml into services.yml.

omarlopesino added a commit to omarlopesino/ddev-aljibe that referenced this issue Oct 7, 2024
@omarlopesino
Copy link
Member Author

@jorgetutor has helped me to discover services.yml file is not neccesary. If we don't commit the file the problem is solved, as the parameters will be taken from default values. Please review this PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant