Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitched and flickering graphics #143

Open
Missingno255 opened this issue Aug 23, 2022 · 6 comments
Open

Glitched and flickering graphics #143

Missingno255 opened this issue Aug 23, 2022 · 6 comments

Comments

@Missingno255
Copy link

Some games like, Addams Family, Terminator 2, and Taito Chase HQ, have flickering or glitched graphics.

The Addams Family has flickering graphics at the top of the screen about 15 or so pixels from the top
20220822_203938-Addams Family, The (Europe)
Correct
20220822_205929-Addams Family, The (Europe)
incorrect

You can see this throughout the first level. It doesn't show very well in the images, but is very noticeable and reproducible. The main character also glitches out when his sprite is flipped horizontally and when walking. I couldn't capture it, but it's also fairly noticeable as artifacts are shown as he changes direction.
both problems are always very reproducible

Terminator 2
Arnold's face is....well not very flattering to say the least!

20220822_204054-Terminator 2 - Judgment Day (Europe)
20220822_204010-Terminator 2 - Judgment Day (Europe)
Always reproducible.

Taito Chase HQ
The graphics for the road and the HUD at the bottom of the screen when turning, flicker and glitch out. This was too hard for me to capture quickly enough, but maybe someone else can get a clear shot of this, as it's VERY noticeable and annoying and also causes performance issues, which you can hear the PSG getting screwed up.

@birdybro
Copy link
Member

The flickering in Addams Family goes away if you set the TV System to PAL, that game was only released in PAL regions, this kind of thing happens on Genesis as well rarely. There is no region detection method for SMS games that is simple enough to be done efficiently, most software emulators get around this by using a large CRC32 database and do a quick match.

I easily reproduced the Terminator 2 error (another EU only game it seems).

Taito Chase HQ is the same as Addams Family, looks like you need to switch TV System to PAL in the Audio & Video options.

@Missingno255
Copy link
Author

Missingno255 commented Aug 25, 2022

The flickering in Addams Family goes away if you set the TV System to PAL, that game was only released in PAL regions, this kind of thing happens on Genesis as well rarely. There is no region detection method for SMS games that is simple enough to be done efficiently, most software emulators get around this by using a large CRC32 database and do a quick match.

I easily reproduced the Terminator 2 error (another EU only game it seems).

Taito Chase HQ is the same as Addams Family, looks like you need to switch TV System to PAL in the Audio & Video options.

Yeah, setting TV system to PAL solved it. I've been wanting to explore the Master System library, and I forgot that this was pretty much a PAL only console, like the Amiga was as a computer.

As for Terminator 2, he's mostly fixed, but he still has a bar or missing section of graphics that goes through him. I don't know if there's another setting I need to set, or if if it's something else, like an emulation problem.

@birdybro
Copy link
Member

birdybro commented Aug 25, 2022

The SMS wasn't pretty much PAL-only, just it had relatively more success in PAL regions (and the most success in Brazil, but that's not PAL, that's PAL-M which uses the NTSC 525-lines 30 FPS system with PAL color encoding).

There are however a good number of PAL-exclusives that is surprising in the library, yeah.

The Terminator 2 issue is likely an emulation/timing problem. I wonder if it's related to this one --> #113

@birdybro
Copy link
Member

birdybro commented Aug 25, 2022

SMS.zip

Try this build for me please @Missingno255 - Just a guess :)

Thanks!

@Missingno255
Copy link
Author

Missingno255 commented Aug 25, 2022

SMS.zip

Try this build for me please @Missingno255 - Just a guess :)

Thanks!

Setting the Z80 mode to turbo, fixes the graphics. Whatever speed that is probably it's normal speed anyway.

@birdybro
Copy link
Member

birdybro commented Aug 25, 2022

The z80 set to turbo actually is not the normal speed. The z80 in the SMS runs at a slower speed than a normal z80. SMS z80 runs at 3.58MHz, the turbo mode brings it up to 5MHz which is similar to a mod you can do on original hardware by swapping oscillators.

What's likely happening is that the timing of the IRQs or the horizontal latching is off somewhere else. Currently the core is using gated clocks with enables instead of synchronous clock enables. I don't have any reason to believe that's the source of the problem, but it might be an improvement to switch to sync w/ clock enables instead to rule out marginal behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants