Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompletableFuture Methods #146

Open
creatorfromhell opened this issue Jul 31, 2022 · 1 comment
Open

Add CompletableFuture Methods #146

creatorfromhell opened this issue Jul 31, 2022 · 1 comment

Comments

@creatorfromhell
Copy link
Contributor

This is mainly a placeholder issue to request that methods returning CompletableFutures be added to Vault. I plan to open a PR for this after PR #138 gets merged, but I wanted to open this as an advance notice so nothing is released as "vault2" when this PR would ultimately cause some incompatibility issues.

  • Yes this is directly from my other issue but it ultimately is the same case, it will be added to the vault2 package. -

This is a pretty straightforward request, which is to add some CompletableFuture methods in order to allow for asynchronous programming inside the economy tree of Vault. This will allow economy developers to be able to predictively determine if the method call is sync or async without doing anything such as what was seen in issue #144 .

@cerealcable
Copy link
Member

Just commenting that we should also have some initial design discussions here like discussed in #145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants