Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows issues #10

Open
Mindful opened this issue May 4, 2021 · 0 comments
Open

Windows issues #10

Mindful opened this issue May 4, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Mindful
Copy link
Owner

Mindful commented May 4, 2021

1. Windows' default encoding when opening files with Python's open() method is apparently not UTF-8 - this causes reading data from quite a few files to fail. This is an easy fix though, we just need to specify UTF-8 as the encoding everywhere we have an open() call with no encoding specified.
2. Fugashi depends on a DLL, and the behavior for handling these changed in 3.8. This issue is documented in polm/fugashi#33 and can currently be worked around by installing with Anaconda and presumably other virtual environments, but it does break installs not using virtual environments. The short term solution is probably just to wrap the fugashi import in a try/catch block and disable it if we can't import it, but long term it would be best if we could just submit a PR to fugashi that fixed the issue. This will require doing some homework about the new Python DLL handling, though.

edit: First issue is solved.

@Mindful Mindful added the bug Something isn't working label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant