You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When instantiating mindsql.llms.OpenAi, the config parameter can only contain parameters to OpenAI's client constructor. This does not include model which must be passed to client.chat.completions.create. In MindSQL's OpenAi.invoke, the model parameter is expected to be in self.config, but it can't be.
Possible Solution
I think it's reasonable to include a model keyword param in the signature of the constructor. Otherwise, it could be removed from the input config prior to passing this config to the OpenAI client (this would avoid any breaking changes).
The text was updated successfully, but these errors were encountered:
Description
When instantiating
mindsql.llms.OpenAi
, the config parameter can only contain parameters to OpenAI's client constructor. This does not includemodel
which must be passed toclient.chat.completions.create
. In MindSQL'sOpenAi.invoke
, themodel
parameter is expected to be inself.config
, but it can't be.Possible Solution
I think it's reasonable to include a
model
keyword param in the signature of the constructor. Otherwise, it could be removed from the input config prior to passing this config to the OpenAI client (this would avoid any breaking changes).The text was updated successfully, but these errors were encountered: