Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge a fork? #1

Open
jakubsuchy opened this issue Apr 2, 2016 · 3 comments
Open

Merge a fork? #1

jakubsuchy opened this issue Apr 2, 2016 · 3 comments

Comments

@jakubsuchy
Copy link

The fork by @KoRa88 currently has all the necessary validation tools, could it be merged here so users don't discover an incomplete toolkit via Composer?

@MiniCodeMonkey
Copy link
Owner

It would be great to merge that!

@danstreeter
Copy link

Agreed - there are a lot of forked upstream fixes that fix some vital things. I'm using this library for a custom skill i'm working on - so might fork and merge all fixes in as one hit to get me going.

@emerham
Copy link

emerham commented May 9, 2017

Looking at the forks and history of each one, @froodley https://github.com/froodley/amazon-alexa-php/network has done a lot of work with code.
Edit
I see now that froodley has identified it is a breaking change from the initial repo and it will no longer work as a possible merge, but there are some good things to possibly add back in. I was trying to get slots working with an app and see that some of the code they added to the Intent class helps in getting some of the data from the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants