Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two unit-tests never pass on the first run #260

Open
dive opened this issue Mar 10, 2020 · 1 comment
Open

Two unit-tests never pass on the first run #260

dive opened this issue Mar 10, 2020 · 1 comment
Assignees
@dive
Labels
bug Categorizes issue or PR as related to a bug. development process Categorizes issue or PR as related to fixing or improving the development process

Comments

@dive
Copy link
Member

dive commented Mar 10, 2020

We have two unit-tests that depend on the environment and never pass on the first run (example on TravisCI):

MobileOrgTests.OrgfileParserTests
789  testParseOrgFileDifferentTodoWords, failed
790  /Users/travis/build/MobileOrg/mobileorg/MobileOrgTests/OrgfileParserTests.swift:96
791  ```
792      } else {
793        XCTFail()
794      }
795  ```
796
797  testParseOrgFileDifferentTodoWords, failed
798  /Users/travis/build/MobileOrg/mobileorg/MobileOrgTests/OrgfileParserTests.swift:106
799  ```
800      } else {
801        XCTFail()
802      }
803  ```

Let's fix them.
@dive dive added bug Categorizes issue or PR as related to a bug. development process Categorizes issue or PR as related to fixing or improving the development process labels Mar 10, 2020
@dive dive self-assigned this Mar 10, 2020
@dive dive mentioned this issue Mar 10, 2020
Merged
@webframp
Copy link
Member

That's gross, thanks for finding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dive dive

Labels
bug Categorizes issue or PR as related to a bug. development process Categorizes issue or PR as related to fixing or improving the development process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dive @webframp