Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing at differently sized groups #23

Open
rotsee opened this issue Feb 12, 2019 · 1 comment
Open

Failing at differently sized groups #23

rotsee opened this issue Feb 12, 2019 · 1 comment

Comments

@rotsee
Copy link

rotsee commented Feb 12, 2019

Thank you for a great library. There seem to be a bug for some numbers patterns with Indian style grouping (the default in Indian English, for instance):

> format("#,##,##0.###",2000000)
'2,000,000'

(Excepted: 20,00,000)

For reference, here's how it looks in Google Closure: https://github.com/google/closure-library/blob/master/closure/goog/i18n/numberformat.js#L892

@rotsee rotsee changed the title Failing at differently sized grops Failing at differently sized groups Feb 12, 2019
@Mottie
Copy link
Owner

Mottie commented Feb 12, 2019

Hi @rotsee!

Oops, yes... the library is only checking the size of the last group. It'll need to be refactored to format the Indian format grouping. Thanks for reporting the problem. I don't know when I'll have time to work on it. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants