Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import error with newer itsdangerous versions #283

Open
simcop2387 opened this issue Mar 3, 2022 · 1 comment
Open

Import error with newer itsdangerous versions #283

simcop2387 opened this issue Mar 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@simcop2387
Copy link
Contributor

Describe the bug
Selene does not work with itsdangerous>2.0.1

This is characterized by:

ImportError: cannot import name 'json' from 'itsdangerous' (/home/mycroft/.local/share/virtualenvs/market-HF8OUXd-/lib/python3.9/site-packages/itsdangerous/__init__.py)

To Reproduce
Try running/installing with Python 3.9, or otherwise updating the Pipfile.lock for the account and market api services. Basically any kind of update

Expected behavior
No import error related to json or itsdangerous.

A quick work around is to declare it as an explicit dependency in the Pipfile, instead of relying only on the Pipfile.lock

[packages]
flask = "<1.1"
requests = "*"
pyjwt = "*"
uwsgi = "*"
markdown = "*"
selene = {path = "./../../shared"}
itsdangerous = "==2.0.1"
@simcop2387 simcop2387 added the bug Something isn't working label Mar 3, 2022
@chrisveilleux
Copy link
Member

Thank you for reporting this issue. It has been resolved in the dev branch and will be included in the next release. See PR #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants