Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception handling and comments #61

Open
jordanpadams opened this issue Oct 31, 2022 · 0 comments
Open

Improve exception handling and comments #61

jordanpadams opened this issue Oct 31, 2022 · 0 comments

Comments

@jordanpadams
Copy link
Member

💡 Description

Per comments on this this PR, there is way too much use of the generic exception in this code, and overuse of core java exceptions that make no sense when applying to PDS (e.g. ArrayIndexOutOfBounds exception should not be used when we are talking about overlapping fields in a PDS array data object).

Additionally, per the comment on PR, could use a comment when some values are very PDS domain specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

No branches or pull requests

1 participant