-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harvest by default overwrites all products #213
harvest by default overwrites all products #213
Comments
I think we have been doing this all along. harvest only uses the bulk interface. It has always use the "index" on the bulk command when adding a document. Interestingly, this means that if it exists, then overwrite it otherwise create it and has been this way since opensearch 1.0 |
@al-niessner hmmm. did we ever do some filtering to prune down what actually makes it into the bulk upload? |
I feel like we definitely had a "skipped" log message, which skipped products. |
Code blame claims has not changed in two years (specifically lines 26-43): |
@al-niessner not sure how/where the "skipped" functionality was implemented in the past, but it was at least logging it as such from the very beginning. are we saying we have been logging it as skipped, but then not actually skipping anything? |
Sorry I had found it and created PR that fixes it but typed the issue wrong in the PR so it did not connect. |
Checked for duplicates
No - I haven't checked
🐛 Describe the bug
From @scholes-ds
When a bundle is loaded twice without -overwrite option, the second time oall the product are overwritten.
🕵️ Expected behavior
I expected the default behavior to not overwrite existing products.
📜 To Reproduce
harvest -c urn-nasa-pds-relab.xml
3.load the bundle again
🖥 Environment Info
...
📚 Version of Software Used
No response
🩺 Test Data / Additional context
No response
🦄 Related requirements
🦄 #xyz
⚙️ Engineering Details
No response
🎉 Integration & Test
No response
The text was updated successfully, but these errors were encountered: