Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harvest by default overwrites all products #213

Open
tloubrieu-jpl opened this issue Nov 12, 2024 · 6 comments · May be fixed by NASA-PDS/registry-common#108
Open

harvest by default overwrites all products #213

tloubrieu-jpl opened this issue Nov 12, 2024 · 6 comments · May be fixed by NASA-PDS/registry-common#108
Assignees

Comments

@tloubrieu-jpl
Copy link
Member

Checked for duplicates

No - I haven't checked

🐛 Describe the bug

From @scholes-ds

When a bundle is loaded twice without -overwrite option, the second time oall the product are overwritten.

🕵️ Expected behavior

I expected the default behavior to not overwrite existing products.

📜 To Reproduce

  1. load a bundle with command harvest -c urn-nasa-pds-relab.xml
  2. update the archive status
    3.load the bundle again
  3. the archive status a re-initialized to "staged"

🖥 Environment Info

  • Version of this software [e.g. vX.Y.Z]
  • Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
    ...

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

🎉 Integration & Test

No response

@al-niessner
Copy link
Contributor

@jordanpadams @tloubrieu-jpl

I think we have been doing this all along. harvest only uses the bulk interface. It has always use the "index" on the bulk command when adding a document. Interestingly, this means that if it exists, then overwrite it otherwise create it and has been this way since opensearch 1.0

@jordanpadams
Copy link
Member

@al-niessner hmmm. did we ever do some filtering to prune down what actually makes it into the bulk upload?

@jordanpadams
Copy link
Member

I feel like we definitely had a "skipped" log message, which skipped products.

@al-niessner
Copy link
Contributor

@jordanpadams
Copy link
Member

@al-niessner not sure how/where the "skipped" functionality was implemented in the past, but it was at least logging it as such from the very beginning. are we saying we have been logging it as skipped, but then not actually skipping anything?

@al-niessner
Copy link
Contributor

@jordanpadams

Sorry I had found it and created PR that fixes it but typed the issue wrong in the PR so it did not connect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

Successfully merging a pull request may close this issue.

4 participants