From 270324eb575edb4f41d4b3d261c4e662ec2fa01b Mon Sep 17 00:00:00 2001
From: robyngit <thiessenbock@nceas.ucsb.edu>
Date: Thu, 17 Oct 2024 14:25:18 -0400
Subject: [PATCH] Move canon'al dataset to the top of citation modal

Canonical dataset citation is now before the "this version" citation in the citation modal on dataset landing pages.

Issue #2541
---
 src/js/views/CanonicalDatasetHandlerView.js |  6 +++--
 src/js/views/citations/CitationModalView.js | 26 +++++++++++++++------
 2 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/src/js/views/CanonicalDatasetHandlerView.js b/src/js/views/CanonicalDatasetHandlerView.js
index 36e3e0f87..632067307 100644
--- a/src/js/views/CanonicalDatasetHandlerView.js
+++ b/src/js/views/CanonicalDatasetHandlerView.js
@@ -368,10 +368,12 @@ define([
           citationModalView.citationContainer.prepend(heading);
 
           // Add the citation for the canonical dataset
+          citationModalView.insertCitation(view.citationModel, false);
+
+          // Add a heading for the canonical dataset citation
           const headingOriginal = document.createElement("h5");
           headingOriginal.textContent = CITATION_TITLE_CANONICAL;
-          citationModalView.citationContainer.append(headingOriginal);
-          citationModalView.insertCitation(view.citationModel);
+          citationModalView.citationContainer.prepend(headingOriginal);
         });
       },
 
diff --git a/src/js/views/citations/CitationModalView.js b/src/js/views/citations/CitationModalView.js
index b55834877..6a8458bee 100644
--- a/src/js/views/citations/CitationModalView.js
+++ b/src/js/views/citations/CitationModalView.js
@@ -6,7 +6,7 @@ define([
   "models/CitationModel",
   "views/CitationView",
   "text!templates/citations/citationModal.html",
-], function ($, _, Backbone, Clipboard, Citation, CitationView, Template) {
+], ($, _, Backbone, Clipboard, Citation, CitationView, Template) => {
   "use strict";
 
   /**
@@ -17,7 +17,7 @@ define([
    * @classcategory Views
    * @extends Backbone.View
    */
-  var CitationModalView = Backbone.View.extend(
+  const CitationModalView = Backbone.View.extend(
     /** @lends CitationModalView.prototype */ {
       /**
        * Classes to add to the modal
@@ -195,22 +195,34 @@ define([
        * views to insert additional citation views into the modal.
        * @param {CitationModel} model - The citation model to use. If not
        * provided, the model passed to the view will be used.
+       * @param {boolean} after - If true, the citation will be inserted after
+       * any existing citations. If false, the citation will be inserted before
+       * any existing citations.
+       * @returns {CitationView} - Returns the CitationView that was inserted
+       * into the modal
        */
-      insertCitation: function (model) {
+      insertCitation(model, after = true) {
         const container = this.citationContainer;
-        if (!container) return;
+        if (!container) return null;
 
         // Create a new CitationView
-        var citationView = new CitationView({
+        const citationView = new CitationView({
           model: model || this.model,
           style: this.style,
           createTitleLink: false,
         });
 
         // Render the CitationView
-        citationView.render();
+        const citationEl = citationView.render().el;
+
         // Insert the CitationView into the modal
-        container.appendChild(citationView.el);
+        if (after) {
+          container.appendChild(citationEl);
+        } else {
+          container.prepend(citationEl);
+        }
+
+        return citationView;
       },
 
       /**