Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll bar to the cesium layer list #2242

Closed
robyngit opened this issue Jan 8, 2024 · 0 comments · Fixed by #2249
Closed

Add scroll bar to the cesium layer list #2242

robyngit opened this issue Jan 8, 2024 · 0 comments · Fixed by #2249
Assignees
@ianguerin
Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center cesium DRP Issues related to the Defense Resiliency Platform enhancement good first issue A good place to start contributing to MetacatUI! pdg Permafrost Discovery Gateway
Milestone
2.28.0

Comments

@robyngit
Copy link
Member

robyngit commented Jan 8, 2024

In a Cesium map, when there are too many layers in in the list, the layer list expands beyond the window height, expanding the height of the page/map with it. Until we support nested data layers (#1773) or other UI elements to organize long lists of layers, the layer list should at least have a scrollbar when it's taller than the window height.
@robyngit robyngit added enhancement pdg Permafrost Discovery Gateway cesium good first issue A good place to start contributing to MetacatUI! DRP Issues related to the Defense Resiliency Platform labels Jan 8, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Jan 20, 2024
@ianguerin
Add CSS to support scrolling in layers toolbar in the Cesium map view
17c0841 
Set a fixed height for body element to force map view to appear on page.
Add some padding to allow for scrollbar in layers toolbar.
Fix issue with cutting off last layer in toolbar on narrow laptop
screen due to a hardcoded value for the header height.

GitHub issue: NCEAS#2242
@ianguerin ianguerin mentioned this issue Jan 20, 2024
Merged
@robyngit robyngit linked a pull request Jan 22, 2024 that will close this issue
Add CSS to support scrolling in layers toolbar in the Cesium map view #2249
Merged
ianguerin added a commit to ianguerin/metacatui that referenced this issue Jan 23, 2024
@ianguerin
Add CSS to support scrolling in layers toolbar in the Cesium map view
ee2bed7 
Set a fixed height for body element to force map view to appear on page.
Add some padding to allow for scrollbar in layers toolbar.
Fix issue with cutting off last layer in toolbar on narrow laptop
screen due to a hardcoded value for the header height.

GitHub issue: NCEAS#2242

temp commit with changes for PR comments
@ianguerin ianguerin self-assigned this Jan 25, 2024
@robyngit robyngit added this to the 2.28.0 milestone Jan 25, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Jan 29, 2024
@ianguerin
Add CSS to support scrolling in layers toolbar in the Cesium map view
81d8d13 
Set a fixed height for body element to force map view to appear on page.
Add some padding to allow for scrollbar in layers toolbar.
Fix issue with cutting off last layer in toolbar on narrow laptop
screen due to a hardcoded value for the header height.

GitHub issue: NCEAS#2242

temp commit with changes for PR comments
@robyngit robyngit added ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center labels Feb 1, 2024
ianguerin added a commit to ianguerin/metacatui that referenced this issue Mar 15, 2024
@ianguerin
Add CSS to support scrolling in layers toolbar in the Cesium map view
30af829 
Set a fixed height for body element to force map view to appear on page.
Add some padding to allow for scrollbar in layers toolbar.
Fix issue with cutting off last layer in toolbar on narrow laptop
screen due to a hardcoded value for the header height.

GitHub issue: NCEAS#2242

temp commit with changes for PR comments
@robyngit robyngit modified the milestones: 2.28.0, 2.29.0 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianguerin ianguerin

Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center cesium DRP Issues related to the Defense Resiliency Platform enhancement good first issue A good place to start contributing to MetacatUI! pdg Permafrost Discovery Gateway
Projects
Arctic Data Center Management Plan Deliverables
Status: Done
Milestone
2.28.0
Development

Successfully merging a pull request may close this issue.

Add CSS to support scrolling in layers toolbar in the Cesium map view ianguerin/metacatui
2 participants
@ianguerin @robyngit