Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Citation model unit tests no longer passing #2557

Open
robyngit opened this issue Oct 21, 2024 · 0 comments · May be fixed by #2558
Open

Citation model unit tests no longer passing #2557

robyngit opened this issue Oct 21, 2024 · 0 comments · May be fixed by #2558
Assignees
@robyngit
Labels
bug citations Related to the CitationView, CitationModel, or Citations collection

Comments

@robyngit
Copy link
Member

Changes made in PR #2552 means that we no longer parse author strings into first name, last name. The unit tests were not update to match this change. This issue entails updating the unit tests to match this new behaviour.
@robyngit robyngit added bug citations Related to the CitationView, CitationModel, or Citations collection labels Oct 21, 2024
@robyngit robyngit self-assigned this Oct 21, 2024
robyngit added a commit that referenced this issue Oct 21, 2024
@robyngit
Fix citation model unit tests
68fa785 
To account for changes to author name parsing in PR #2552

Fixes issue #2557
@robyngit robyngit linked a pull request Oct 21, 2024 that will close this issue
Open
@robyngit robyngit linked a pull request Oct 21, 2024 that will close this issue
Fix citation model unit tests #2558
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
bug citations Related to the CitationView, CitationModel, or Citations collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix citation model unit tests NCEAS/metacatui
1 participant
@robyngit