Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch 7 can't work without initial_master_nodes #289

Open
widhalmt opened this issue Oct 24, 2023 · 1 comment
Open

Elasticsearch 7 can't work without initial_master_nodes #289

widhalmt opened this issue Oct 24, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@widhalmt
Copy link
Member

The check in https://github.com/NETWAYS/ansible-collection-elasticstack/blob/main/roles/elasticsearch/templates/elasticsearch.yml.j2#L31 is wrong at least for Elasticsearch 7. Even a single node cluster needs this to be set.

If I remember correctly, we had to remove it on Elasticsearch 8 single node clusters to not get error messages. So either we live with the message or we introduce yet another check and set it always on 7 and only on multinode cluster on 8.

@widhalmt widhalmt added the bug Something isn't working label Oct 24, 2023
@widhalmt widhalmt added this to the 1.0.0 milestone Oct 24, 2023
@ivareri
Copy link
Contributor

ivareri commented Oct 24, 2023

Would it be a cleaner solution to have two templates? ie elasticsearch-7.yml.j2 and elasticsearch-8.yml.j2. Some changes would have to be done twice, but I think the template files would be easier to read.

I think the only required change to other files would be changing src line in Configure Elasticsearch , but I haven't tested it.

src: elasticsearch-{{ elasticstack_release }}.yml.j2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants