Feature: Button that allows the user to switch the side where the sidebar is displayed #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebar is displayed
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tomaspalma
requested changes
Nov 14, 2024
Comment on lines
+88
to
+94
| <button | ||
| onClick={toggleSidebarPosition} | ||
| className="hidden md:inline-flex items-center justify-center w-8 h-8 bg-primary text-white rounded hover:text-opacity-75" | ||
| > | ||
| <ArrowsRightLeftIcon className='h-4 w-4' /> | ||
| </button> | ||
|
|
There was a problem hiding this comment.
I don't think the button to switch sides should be here on the navbar because not all pages have the sidebar and it looks weird for the about page and the FAQ page to have such button.
Can you move it to some place inside the sidebar? For example, near the download button or on the bottom of the sidebar.
tomaspalma
requested changes
Nov 14, 2024
| </SentryRoutes> | ||
| </CombinedProvider> | ||
| </BrowserRouter> | ||
| <SidebarProvider> |
There was a problem hiding this comment.
In the same light as the previous comment, since the sidebar button to change sides should not be global, it does not really make sense to render the SidebarProvider here.
It should be inside the TimeTableScheduler.tsx page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203
Added a button besides the DarkModeSwitch button that changes the side of the sidebar from the right to the left and vice-versa.