-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source type field: switch to radio button and text field #23
Comments
Tangential issue addressed in PR #30
Original issue is still relevant, as it restricts the vocabulary of figures and tables. |
Example available in: https://github.com/dwsideriusNIST/isotherm-digitizer-panel/tree/feature-radiobuttons Two issues remaining:
|
So, do we still want to change this? The question is: for automated queries, do we need to know more than whether an entry is tabular or not? P.S. A typical user interface / schema definition tip is to use boolean flags only when you can mathematically prove that there are only ever going to be two options. I.e. even if we currently just have a switch tabular/digitized, on the JSON one might want to leave the possibility open (e.g. by calling the field |
After working on this (I have a feature branch with a working version, but have never made a PR), I questioned its necessity. Originally, my intention was to hook the Thus, I'm inclined to drop this feature request. Maybe we eventually add a feature in the plot tab where warnings or other messages are included. One message could be Regarding a more verbose API, these are all features that I will add to a to-do list. Maybe API v3.0 will be a re-think of the metadata structure. |
This is a change I had planned for the PHP digitizer and hadn't pushed upstream yet. The idea is that the user selects either figure or table via radio button, then fills in a field with the figure or table number. Then if the source type is table, set another key in the output JSON:
"tabular": 1
A user (CS) asked if I could label isotherms that are based on tabular data (as opposed to digitized from figures) so that he/she could generate a high-confidence subset of isotherms.
The text was updated successfully, but these errors were encountered: