Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review: revert build-workflow addition from #551 #652

Open
egpbos opened this issue Aug 30, 2024 · 2 comments
Open

code review: revert build-workflow addition from #551 #652

egpbos opened this issue Aug 30, 2024 · 2 comments

Comments

@egpbos
Copy link
Member

egpbos commented Aug 30, 2024

This is a belated review of #551.

I don't see what the addition of the build.yml workflow adds to CI. The useful part of the pre-existing workflow was to run the tests. Installing the template repo as a package is not a goal in itself, so we need not test it separately.
@egpbos
Copy link
Member Author

egpbos commented Aug 30, 2024 •
edited
Loading

Related to #651. What I would suggest is that we just rename build.yml to lint.yml and remove the build workflow from the file, killing two birds with one stone.

@egpbos
Copy link
Member Author

egpbos commented Aug 30, 2024 •
edited
Loading

Never mind, I see the other issue is actually about the generated package. So my suggestion here is to just remove build.yml in the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egpbos