Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing glob star in routing_output field #173

Open
aaraney opened this issue Aug 22, 2024 · 2 comments
Open

Consider allowing glob star in routing_output field #173

aaraney opened this issue Aug 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request ngen.cal Related to ngen.cal package question Further information is requested

Comments

@aaraney
Copy link
Member

aaraney commented Aug 22, 2024

routing_output: Optional[Path] = Field(default=Path("flowveldepth_Ngen.csv"))

Its not uncommon that software that creates model outputs (e.g. ngen or t-route) names their output files based on factors like the associated nexus or catchment id, the current time, or the simulation start time. Often a prefix or suffix is used (e.g. troute_output_{{start_time}}.csv) with the output format. It would be convenient if a glob star could be provided in the name of the routing_output field so that you don't have to know a priori the full name of the routing_output file. For example routing_output: troute_output_*.csv.

@aaraney aaraney added enhancement New feature or request question Further information is requested ngen.cal Related to ngen.cal package labels Aug 22, 2024
@aaraney aaraney self-assigned this Aug 22, 2024
@aaraney
Copy link
Member Author

aaraney commented Aug 22, 2024

@hellkite500, what are your thoughts on this?

@hellkite500
Copy link
Member

I think this is reasonable. We would probably want to pass the pattern down to the output hook and let it decide how to handle it, especially the case when the pattern matches more than one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ngen.cal Related to ngen.cal package question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants