Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional output_root to ngen.config #84

Closed
aaraney opened this issue Nov 24, 2023 · 1 comment · Fixed by #87
Closed

Add optional output_root to ngen.config #84

aaraney opened this issue Nov 24, 2023 · 1 comment · Fixed by #87
Assignees
@aaraney
Labels
enhancement New feature or request good first issue Good for newcomers ngen.config Related to ngen.config package

Comments

@aaraney
Copy link
Member

aaraney commented Nov 24, 2023 •
edited
Loading

Add optional output_root: Optional[Path] key. Need to double check all the places where it is accepted. I think just ngen.config.NgenRealization? This was added to NextGen in NOAA-OWP/ngen#531.
@aaraney aaraney self-assigned this Nov 24, 2023
@aaraney aaraney added enhancement New feature or request good first issue Good for newcomers ngen.config Related to ngen.config package labels Nov 24, 2023
@aaraney aaraney changed the title Add optional output_root to ngen.config.NgenRealization Add optional output_root to ngen.config.Realization Nov 24, 2023
@aaraney aaraney changed the title Add optional output_root to ngen.config.Realization Add optional output_root to ngen.config Nov 24, 2023
@aaraney
Copy link
Member Author

aaraney commented Dec 12, 2023

Verified that this is only a top level key. See this test and this doc.

aaraney added a commit to aaraney/ngen-cal that referenced this issue Dec 12, 2023
@aaraney
add optional output_root key (NOAA-OWP#84)
0f15a88
@aaraney aaraney mentioned this issue Dec 12, 2023
Merged
10 tasks
hellkite500 pushed a commit that referenced this issue Jan 22, 2024
@aaraney @hellkite500
add optional output_root key (#84)
58bc47b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaraney aaraney

Labels
enhancement New feature or request good first issue Good for newcomers ngen.config Related to ngen.config package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optional Ngen realization output_root key aaraney/ngen-cal
1 participant
@aaraney