Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for an output_root directory #857

Closed
stcui007 opened this issue Jul 18, 2024 · 7 comments
Closed

Need for an output_root directory #857

stcui007 opened this issue Jul 18, 2024 · 7 comments
Assignees

Comments

@stcui007
Copy link
Contributor

stcui007 commented Jul 18, 2024

In recent CONUS baseline testing, it is realized that a specific sub-directory is needed to store the ngen output data files, which count to over a million. Current form of realization files writes these files to project directory, which makes working in the directory extrmely incovennient. For example, a simple ls command takes many minutes to complete. Then you cannot spot the file you are looking for. In general, such situation would arise for any relatively large basin.

Code exists that accommodate this. But requires the user to create the sub-directory in advance, otherwise, it default to project directory. A updated version of the code added a safety feature for case the user forget to create the needed sub-directory.

To alleviate the problem, all current realization files need to add the following line:
"output_root": "./output_dir/"
at the top level of the realization json tree. That will make ngen to write all the output files to ./output_dir. You are free to choose your own favorite name instead of "output_dir". At the time of this writing, if you forget to create ./output_dir/ in advance before running, the default output directory is the project directory.

The updated code (to be merged) throws an error if you do not created the output_root before starting ngen to remind you to create the subdirectory before things get messy. It may require all updated realization to be merged first.

Current behavior

Large amount of output files when running ngen for CONUS or any large basin.

Expected behavior

Output files are written to a user specified directory to keep the project directory clean.

Steps to replicate behavior (include URLs)

  1. Running ngen in framework for a relatively large basin

Screenshots

@aaraney
Copy link
Member

aaraney commented Jul 18, 2024

Once #744 this should no longer be an issue.

@stcui007
Copy link
Contributor Author

stcui007 commented Jul 18, 2024 via email

@program-- program-- mentioned this issue Jul 18, 2024
11 tasks
@SnowHydrology
Copy link
Contributor

@aaraney Will #744 also enable a user to change the name of the output files?

@aaraney
Copy link
Member

aaraney commented Aug 1, 2024

@SnowHydrology, not the output file name, the output directory name.

Potentially? The design we have right now allows it, but that could change.

@SnowHydrology
Copy link
Contributor

Thanks @aaraney. To clarify, the design would currently allow the user to change the output file names, but it may not in the future?

@aaraney
Copy link
Member

aaraney commented Aug 1, 2024

@SnowHydrology, correct.

@stcui007 stcui007 self-assigned this Aug 7, 2024
@stcui007
Copy link
Contributor Author

stcui007 commented Aug 7, 2024

Closed via#855.

@stcui007 stcui007 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants