You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Standard names are generally of the form object__quantity.
For example: channel_bank_water__volume-per-length_flow_rate ("lateral flow" into side of channel)
@AminTorabi-NOAA This is what I am working on updating current variable names according to CSDMS standard names.
In the codes attached here, commented-out names are existing or internal names t-route use and names on the left on each code line are my suggested name. We can modify them as necessary as well.
Changing names should involve updating the same or similar names used in related files, so let's suggest new names here in this Issue first until we all agree on.
We've used internal t-route variables names in our BMI modules, but we should update these to conform to CSDMS standard names.
Current behavior
In bmi_troute.py and bmi_reservoirs.py, variable names are mostly internal t-route names.
We also need to update the dictionary linking the (should be) standard CSDMS names and internal t-route names, along with respective units.
Once both of those are complete, we can change the initialization of variables to be a simple for loop.
Expected behavior
Standard names are generally of the form object__quantity.
For example:
channel_bank_water__volume-per-length_flow_rate ("lateral flow" into side of channel)
More examples.
Steps to replicate behavior (include URLs)
Screenshots
The text was updated successfully, but these errors were encountered: