Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Coil:Cooling:DX:VariableSpeed and Heating to AirflowNetwork:Distribution:Component:Coil #10671

Open
3 tasks
mjwitte opened this issue Aug 20, 2024 · 1 comment · May be fixed by #10791
Open
3 tasks

Add Coil:Cooling:DX:VariableSpeed and Heating to AirflowNetwork:Distribution:Component:Coil #10671

mjwitte opened this issue Aug 20, 2024 · 1 comment · May be fixed by #10791
Assignees
@lymereJ
Labels
AirflowNetwork Related primarily on airflow-network portions of the codebase NewFeatureRequest This "issue" is a new feature request, not a defect report

Comments

@mjwitte
Copy link
Contributor

mjwitte commented Aug 20, 2024

Issue overview

Coil:Cooling:DX:VariableSpeed and Coil:Heating:DX:VariableSpeed are missing from the valid coil types for AirflowNetwork:Distribution:Component:Coil.

AirflowNetwork:Distribution:Component:Coil,
      \min-fields 4
      \memo This object defines the name of a coil used in an air loop.
 A1 , \field Coil Name
      \required-field
      \type object-list
      \reference AirflowNetworkComponentNames
      \object-list AFNCoilNames
      \note Enter the name of a cooling or heating coil in the primary Air loop.
 A2 , \field Coil Object Type
      \required-field
      \type choice
      \key Coil:Cooling:DX
      \key Coil:Cooling:DX:SingleSpeed
      \key Coil:Cooling:DX:TwoSpeed
      \key Coil:Heating:Fuel
      \key Coil:Heating:Electric
      \key Coil:Heating:DX:SingleSpeed
      \key Coil:Cooling:Water
      \key Coil:Heating:Water
      \key Coil:Cooling:Water:DetailedGeometry
      \key Coil:Cooling:DX:TwoStageWithHumidityControlMode
      \key Coil:Cooling:DX:MultiSpeed
      \key Coil:Heating:DX:MultiSpeed
      \key Coil:Heating:Desuperheater
      \key Coil:Heating:Electric:MultiStage
      \key Coil:Heating:Gas:MultiStage
      \note Select the type of coil corresponding to the name entered in the field above.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus 22.2
  • Helpdesk ticket number 16742.

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to EnergyPlus Defect Complexity (Github Project)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@mjwitte mjwitte added the NewFeatureRequest This "issue" is a new feature request, not a defect report label Aug 20, 2024
@mjwitte
Copy link
Contributor Author

mjwitte commented Aug 20, 2024

Looks like this should be a relatively small code change. Here's what was added to support Coil:Cooling:DX as part of #7792

https://github.com/NREL/EnergyPlus/pull/7792/files#diff-63115c54625b7780c3ff61fad9cf90ad869243ab05cd842ac8b05d0c50be564eL9883-R9902

@lymereJ lymereJ added the AirflowNetwork Related primarily on airflow-network portions of the codebase label Aug 22, 2024
@lymereJ lymereJ self-assigned this Oct 13, 2024
@lymereJ lymereJ linked a pull request Oct 14, 2024 that will close this issue
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lymereJ lymereJ

Labels
AirflowNetwork Related primarily on airflow-network portions of the codebase NewFeatureRequest This "issue" is a new feature request, not a defect report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Coil:*:DX:VariableSpeed as valid AirflowNetwork:Distribution:Component:Coil NREL/EnergyPlus
2 participants
@mjwitte @lymereJ