Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updateSlider to go all the way left or right #170

Open
scotself opened this issue Dec 30, 2020 · 0 comments
Open

Allow updateSlider to go all the way left or right #170

scotself opened this issue Dec 30, 2020 · 0 comments

Comments

@scotself
Copy link

Line #338 in juxtapose.js, in the updateSlider function, is there a particular reason it's
if (leftPercentNum > 0 && leftPercentNum < 100) {
instead of
if (leftPercentNum >= 0 && leftPercentNum <= 100) {
?

The way it is now, I cannot make a button which, on click, slides the slider all the way right or left ('show only before' or 'show only after' button). For now, I just grabbed the code (great work, btw!!) and made a copy of our own and made this change locally, but that would be a simple and welcome change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant