Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll on popup windows (i.e. Text Editor, FTP Program) doesn't work, even if content goes beyond window dimensions #71

Open
bdin opened this issue Oct 7, 2015 · 6 comments
Assignees

Comments

@bdin
Copy link
Member

bdin commented Oct 7, 2015

See: https://learn.knightlab.com/lesson/create-basic-website/
Click on FTP program; depending on how large your window is, the various FTP programs may not all appear in the popup window, and you don't have the ability to scroll down to view the rest of the programs

@JoeGermuska
Copy link
Member

This is deployed to production. @emilywithrow @bdin or someone please verify and close this if satisfied

@zachwise
Copy link
Member

Passing through the scroll change is the reason scroll blocking was implemented ref issue #7. I'll take a look at the issue. The solution that implemented scroll blocking was flawed but deemed better than the alternative until someone had the time to tackle this.

@JoeGermuska
Copy link
Member

As far as I can tell this is fixed. I'm just waiting for someone to review it.

We may need to figure out a way to ring people's bells louder.

@zachwise
Copy link
Member

It's definitely not fixed.

@JoeGermuska
Copy link
Member

Here's a screencap of me scrolling the first capsule-unit on Create a Basic Website learn-scroll

Using the trackpad on a MacBook running Mac OS 10.10.5 and Chrome 46.0.2490.71

I see now that it doesn't work on Firefox or Safari 😞

@JoeGermuska
Copy link
Member

noted by @bdin in Slack:

in the inspect element section, it says #capsule-content.capsule-unit is still set to overflow: hidden, but when i change it to scroll it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants