Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play/pause controls are not accessible with keyboard #93

Open
vosnier opened this issue Mar 31, 2021 · 7 comments
Open

Play/pause controls are not accessible with keyboard #93

vosnier opened this issue Mar 31, 2021 · 7 comments

Comments

@vosnier
Copy link

vosnier commented Mar 31, 2021

Play/pause controls can only be activated with a mouse. In order to make the controls accessible for blind users, they need to be focusable when navigating with keyboard and it should be possible to play and pause the audio using the keyboard only.

@JoeGermuska
Copy link
Member

cleaning out the open issues.

We acknowledge that this is true, and it would be a worthy effort to improve SoundCite's accessibility.

The tool is not under active development, but we would gladly accept a pull request; if not, there may yet be a time when we are able to direct energy to this issue.

@aarongustafson
Copy link

@vosnier I was running into this as well. Did you have specific thoughts in mind? I was thinking of the following:

  • role="button"
  • tabindex="0"

I feel like we need to figure labelling & status as well. Some sort of indication of what the button does and when it’s playing.

@JoeGermuska
Copy link
Member

As noted above, we would welcome a PR that addresses this.

I feel like there are potential complications in how clips interact with other content on the page, specifically if we try to determine the correct tabindex in a vacuum. Even absent interactions, it's entirely possible that people would not create clips in the order that they use them on their page.

The role attribute seems easy enough, and there's a natural hook to change a label from 'playing' to something else when the classes are changed to control the appearance of the ▶️/⏸ indicator.

@aarongustafson
Copy link

I feel like there are potential complications in how clips interact with other content on the page, specifically if we try to determine the correct tabindex in a vacuum. Even absent interactions, it's entirely possible that people would not create clips in the order that they use them on their page.

A tabindex of 0 is always in the normal flow (it just makes it keyboard-focusable). The interaction would be analogous to a link.

The role attribute seems easy enough, and there's a natural hook to change a label from 'playing' to something else when the classes are changed to control the appearance of the ▶️/⏸ indicator.

That's my thought as well. Still need to explain what the button does to folks, but I think we can figure that out too. A colleague of mine is talking a look at this as well. We specialize in accessibility, so we'll make sure the PR meets the necessary quality threshold there.

@vnessamartinez
Copy link

Hi, @aarongustafson. May I ask how far you are in the process? A colleague was interested in using this tool for a project this month, but we noticed that it's not accessible. Is there anything that we can do to help?

@aarongustafson
Copy link

Hi, @aarongustafson. May I ask how far you are in the process? A colleague was interested in using this tool for a project this month, but we noticed that it's not accessible. Is there anything that we can do to help?

Adding @JGibson2019, who was looking into this.

@JGibson2019
Copy link

Hey all! I haven't gotten to this issue yet but wanted to update the thread in case anyone else has spare cycles! Otherwise, I'll circle back later this spring :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants