Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hikahana/323-fix-import-types-graphql #324

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

hikahana
Copy link
Collaborator

@hikahana hikahana commented Nov 7, 2024

対応Issue

概要

graphqlのimportパスを修正しました。

実装詳細

画面スクリーンショット等

テスト項目

  • type/graqhql と types/graphqlで検索賭けてすべて修正できているか確認する。
  • import {type hoge}みたいな感じでまとまってたらok
  • [ ]

備考

@github-actions github-actions bot added frontend bug Something isn't working labels Nov 7, 2024
@hikahana hikahana requested a review from TkymHrt November 7, 2024 10:23
@TkymHrt TkymHrt requested a review from Copilot November 20, 2024 08:10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (9)
  • view-admin/src/styles/Home.module.css: Language not supported
  • view-user/src/components/common/cards/NumberCardList/NumberCardList.tsx: Evaluated as low risk
  • view-admin/src/pages/prizes/index.tsx: Evaluated as low risk
  • view-user/src/pages/index.tsx: Evaluated as low risk
  • view-user/src/pages/prizes/index.tsx: Evaluated as low risk
  • view-admin/src/type/graphql.ts: Evaluated as low risk
  • view-user/src/components/common/cards/PrizeCard/PrizeCard.tsx: Evaluated as low risk
  • view-admin/src/components/common/BingoResult/BingoResult.tsx: Evaluated as low risk
  • view-admin/src/components/common/UpdateNumberModal/UpdateNumberModal.tsx: Evaluated as low risk
Comments skipped due to low confidence (3)

view-admin/src/pages/index.tsx:44

  • [nitpick] The variable name isopenBool is ambiguous. It should be renamed to isOpenBool.
const isOpenBool = () => setIsOpened(!isOpened);

view-admin/src/pages/index.tsx:162

  • The class name flexerror should be corrected to flexError.
<div className={styles.flexError}>

view-admin/src/pages/index.tsx:196

  • The class name flexerror should be corrected to flexError.
<div className={styles.flexError}>
@@ -1,4 +1,4 @@
import React, { ReactNode } from "react";
import React from "react";
Copy link
Collaborator

@TkymHrt TkymHrt Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要です!他のファイルもついでに!o(^o^)o

Suggested change
import React from "react";

@TkymHrt
Copy link
Collaborator

TkymHrt commented Nov 20, 2024

import type { GetListPrizesQuery } from "@/types/graphql";

import { GetListPrizesQuery } from "@/types/graphql";

@TkymHrt
Copy link
Collaborator

TkymHrt commented Nov 20, 2024

import type { SubscribeListNumbersSubscription } from "@/types/graphql";

import { SubscribeListNumbersSubscription } from "@/types/graphql";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphQLのインポートパスの修正
2 participants