Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on convert_str_id_to_int in FuzzyDedup Scripts #447

Open
praateekmahajan opened this issue Dec 20, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@praateekmahajan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
During the minhash script we implicitly convert str id to 2 int ids (doc_id + dataset_id). This is different from the FuzzyDuplicate(...) api where no such conversion is performed. In an ideal world, we don't rely on conversion of a string to int ids.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@praateekmahajan praateekmahajan added the enhancement New feature or request label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant