Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate access property strided loops are wrong. #2605

Open
wmaxey opened this issue Oct 21, 2024 · 0 comments · May be fixed by #2607
Open

Associate access property strided loops are wrong. #2605

wmaxey opened this issue Oct 21, 2024 · 0 comments · May be fixed by #2607
Assignees

Comments

@wmaxey
Copy link
Member

wmaxey commented Oct 21, 2024

Copied from discussion:

The following code snippet is part of the apply_access_property implementation. My concern is that doesn't this apply the evict_last property to addresses in multiples of _LINE_SIZE_LINE_SIZE = 128128? Shouldn't we actually do this in multiples of _LINE_SIZE? That would require replacing __i += _LINE_SIZE with __i += 1.
Please correct me if I am wrong if I am missing something.
Thanks

for (std::size_t __i = 0; __i < __end; __i += _LINE_SIZE) {
  asm volatile ("prefetch.global.L2::evict_last [%0];" ::"l"(__p + (__i * _LINE_SIZE)) :);
}
@wmaxey wmaxey linked a pull request Oct 21, 2024 that will close this issue
2 tasks
@wmaxey wmaxey self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

1 participant