Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hostNetwork = true #962

Open
jihuiyang-x opened this issue Sep 20, 2024 · 4 comments
Open

Enable hostNetwork = true #962

jihuiyang-x opened this issue Sep 20, 2024 · 4 comments

Comments

@jihuiyang-x
Copy link

currently this plugin is a daemonset that runs in k8s cluster. it should be made to use hostNetwork=true to not use unnecessary ips.

@klueska
Copy link
Contributor

klueska commented Sep 20, 2024

Can you elaborate on why you want this component to have access to the host network at all? It doesn't perform any network related operations.

@jihuiyang-x
Copy link
Author

it does not. but not setting hostNetwork = true for daemonset will consume a lot of ips in k8s. please make this a configurable value.

@klueska
Copy link
Contributor

klueska commented Sep 26, 2024

I did a little research and it does indeed seem that this is the standard practice for avoiding unnecessary IPs from being allocated. @elezar Is this something we can get added to the next release? I would say we should definitely expose it as a helm setting, but actually make hostNetwork: true the default.

@chipzoller
Copy link
Contributor

Just my two cents here but making it configurable could be beneficial for the reason provided, but setting it as the default I would not do. Host networking is a potential security vector and adding this as a default would violate another of the controls in the baseline profile of the Pod Security Standards. Pods which violate this profile by default should only do so when expressly needed which as Kevin points out is not the case in the device plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants