-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable hostNetwork = true #962
Comments
Can you elaborate on why you want this component to have access to the host network at all? It doesn't perform any network related operations. |
it does not. but not setting |
I did a little research and it does indeed seem that this is the standard practice for avoiding unnecessary IPs from being allocated. @elezar Is this something we can get added to the next release? I would say we should definitely expose it as a helm setting, but actually make |
Just my two cents here but making it configurable could be beneficial for the reason provided, but setting it as the default I would not do. Host networking is a potential security vector and adding this as a default would violate another of the controls in the baseline profile of the Pod Security Standards. Pods which violate this profile by default should only do so when expressly needed which as Kevin points out is not the case in the device plugin. |
currently this plugin is a daemonset that runs in k8s cluster. it should be made to use
hostNetwork=true
to not use unnecessary ips.The text was updated successfully, but these errors were encountered: