Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The mismatch between the Overview in the paper and the source code #39

Open
jixiedy opened this issue Aug 16, 2024 · 1 comment
Open

Comments

@jixiedy
Copy link

jixiedy commented Aug 16, 2024

Dear Author,
Thank you for your excellent work.

I'm very disturbed by the problem of the mismatch between the Overview in the paper and the corresponding source code:
Why the key functions init_two_view and add_view_v2 are not used at all in the project? How do you get the Local 3DGS & Camera Pose between neighboring frames? I can't understand it, can you please answer my confusion? Thanks.

I found though the following code:
gauss_params = self.init_two_view(0, end_frame, pipe, copy(self.optim_cfg))
pcd_new, local_gauss_params = self.add_view_v2(fidx, fidx-1)

However, I can't find the code where gauss_params, pcd_new and local_gauss_params are used in any other area of the project.

@OasisYang
Copy link
Collaborator

Hi, the local gaussian is optimized from Line 232 to Line290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants