Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] wait_for_response with multiple TTS languages #138

Open
NeonDaniel opened this issue Aug 11, 2023 · 1 comment
Open

[BUG] wait_for_response with multiple TTS languages #138

NeonDaniel opened this issue Aug 11, 2023 · 1 comment
Labels
bug Something isn't working question Further information is requested

Comments

@NeonDaniel
Copy link
Member

Description

If multiple TTS languages are configured, after the first playback completes the microphone will start listening for a response.

Steps to Reproduce

  • Enable a secondary TTS language
  • Call an intent that requires confirmation

Relevant Code

https://github.com/NeonGeckoCom/neon_audio/blob/dev/neon_audio/service.py#L115-L120

Other Notes

Consider if these should have multiple speak_ident parameters, or await a second confirmation if 2 languages are configured
@NeonDaniel NeonDaniel added the bug Something isn't working label Aug 11, 2023
@NeonDaniel NeonDaniel added the question Further information is requested label May 15, 2024
@NeonDaniel NeonDaniel moved this to Low Priority in Community Projects May 15, 2024
@NeonDaniel
Copy link
Member Author

This will have changed with refactoring done in ovos-audio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
Community Projects
Status: Low Priority
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeonDaniel