Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] tts-plugin module not matching pypi name causes failure to load #167

Open
mikejgray opened this issue Feb 24, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@mikejgray
Copy link
Contributor

Description

In an edge case where the module of a TTS plugin does not match its PyPi name, and tts.package_spec is not available, the audio service will attempt to infer a package to install from PyPi based on tts.module. When it cannot find that package, the service errors out and does not load TTS, even if the plugin is available from extra_dependencies.audio.

Steps to Reproduce

extra_dependencies:
  audio:
    - neon-tts-plugin-coqui-remote
tts:
  module: mozilla_remote
  mozilla_remote: 127.0.0.1/api/tts

The issue is resolved by adding tts.package_spec: neon-tts-plugin-mozilla-remote.

Relevant Code

if config["tts"].get("package_spec"):

Other Notes

No response

@mikejgray mikejgray added the bug Something isn't working label Feb 24, 2024
@NeonDaniel NeonDaniel self-assigned this May 15, 2024
@NeonDaniel NeonDaniel moved this to In Progress in Community Projects May 15, 2024
@NeonDaniel NeonDaniel moved this from In Progress to Other Helpful Tasks in Community Projects May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Other Helpful Tasks
Development

No branches or pull requests

2 participants