Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate time locks #111

Closed
11 tasks done
aszepieniec opened this issue Feb 26, 2024 · 0 comments · Fixed by #118
Closed
11 tasks done

integrate time locks #111

aszepieniec opened this issue Feb 26, 2024 · 0 comments · Fixed by #118

Comments

@aszepieniec
Copy link
Contributor

aszepieniec commented Feb 26, 2024 •
edited
Loading

PR #107 adds support for time locks, but several integration-related tasks remain.

  • test that un-time-locked UTXOs can be spent
  • test that time-locked UTXOs cannot be spent if the release date is in the future
  • test that time-locked UTXOs can be spend if the release date is in the past
  • test that premine recipients cannot spend their time-locked coins before the release date
  • test that premine recipients can spend their time-locked coins after the release date
  • modify balance calculator: count only spendable UTXOs
  • add balance calculator for time-locked UTXOs
  • modify transaction compiler: select only spendable UTXOs
  • test that compiling a transaction that spends too much fails, even if spendable balance + time-locked balance is enough
  • add CLI command to list all UTXOs with release dates and display amounts, with totals
  • display time-locked balance in dashboard
@aszepieniec aszepieniec mentioned this issue Mar 9, 2024
Merged
aszepieniec added a commit that referenced this issue Mar 14, 2024
@aszepieniec
Merge pull request #118 from Neptune-Crypto/aszepieniec/#111-time-loc…
e240f96 
…k-integration

feat: Time lock integration

 - Use and enforce time-lock logic for UTXOs that come with time-locks. Specifically:
   - Before release, the transaction is invalid.
   - After release the transaction is valid (or at least, not invalidated by the time-lock).
   - No effect on UTXOs that are not time-locked.
 - Time-lock premine allocations for six months following launch.
 - Convenience methods for computing available and time-locked balances.
 - User-facing methods for reporting on available and time-locked balances and UTXOs.
 - Drop support for partially proven transactions. Headache to work with. Better to add back later.
 - Revise consensus logic abstractions. Will be addressed again in a later PR.

Closes #111.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Time lock integration Neptune-Crypto/neptune-core
1 participant
@aszepieniec