Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.febuild should be a JS file #69

Open
quicoto opened this issue Jul 12, 2022 · 3 comments
Open

.febuild should be a JS file #69

quicoto opened this issue Jul 12, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@quicoto
Copy link
Member

quicoto commented Jul 12, 2022

The configuration defined on .febuild is JS, for instance:

module.exports = {
  general: {
      defaultTasks: [ "styles", "webpack" ],
  }
}

Yet the file has no .js extension. Thus, not taking advance or code highlight or linting.

Can we make it a JavaScript file instead?

@quicoto quicoto added the enhancement New feature or request label Jul 12, 2022
@quicoto
Copy link
Member Author

quicoto commented Jul 12, 2022

@easingthemes @raohmaru Thoughts?

@raohmaru
Copy link
Contributor

Although you can manually define the language of a file in any modern IDE, this proposal does not hurt. Notwithstanding I would keep the support for plain .febuild files for backwards compatibility.

@easingthemes
Copy link
Member

I like .febuild, it gives something unique to this library :).
But of course we can support both. Should not be that complex change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants